fix: small typos in comments in types.go by gonmmarques · Pull Request #2804 · openshift/api

gonmmarques · 2026-04-15T01:44:04Z

No description provided.

openshift-merge-bot · 2026-04-15T01:44:08Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-04-15T01:44:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ac01953d-b14c-4fe7-b62d-0a52f999c3e9

📥 Commits

Reviewing files that changed from the base of the PR and between 3d57b9d and 137a031.

📒 Files selected for processing (1)

security/v1/generated.proto

✅ Files skipped from review due to trivial changes (1)

security/v1/generated.proto

📝 Walkthrough

Walkthrough

Fixed two spelling errors in documentation strings: in security/v1/types.go, DefaultAddCapabilities comment changed "capabiility" → "capability"; in payload-manifests/crds/0000_03_config-operator_01_securitycontextconstraints.crd.yaml, SeccompProfiles description changed "specifid" → "specified". Equivalent comment-only fixes were also applied in security/v1/generated.proto. No code logic, type definitions, field names, JSON/protobuf tags, validation rules, or functional behavior were modified.

🚥 Pre-merge checks | ✅ 9 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a pull request description explaining the typo fixes and their impact on the documentation and generated files.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing typos in comments across multiple files including types.go, protobuf, and CRD YAML.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	The PR modifies only non-test files with comment spelling corrections, no Ginkgo test code is altered.
Test Structure And Quality	✅ Passed	PR contains only typo fixes in comments and documentation across configuration/type files with no test code modifications.
Microshift Test Compatibility	✅ Passed	PR contains only spelling corrections in comments and generated files. No Ginkgo e2e tests are added or modified, making this check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR contains only comment-only spelling corrections in type definition files and CRD YAML schema files. No Ginkgo e2e tests are present, so the check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains only spelling corrections in SecurityContextConstraints documentation comments, with no deployment manifests, scheduling constraints, or topology-dependent changes.
Ote Binary Stdout Contract	✅ Passed	Pull request contains only spelling corrections in comments within API type definition files with no changes to executable code or process-level functions.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. Changes are limited to comment/documentation corrections in non-test files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-04-15T01:44:26Z

Hello @gonmmarques! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci · 2026-04-15T01:44:27Z

Hi @gonmmarques. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

everettraven

Thanks for the PR @gonmmarques

It looks like this needs to re-generate the generated files that are impacted by this change still.

Running PROTO_OPTIONAL=true make update should do the trick.

gonmmarques · 2026-04-16T13:37:10Z

Thanks for the PR @gonmmarques

It looks like this needs to re-generate the generated files that are impacted by this change still.

Running PROTO_OPTIONAL=true make update should do the trick.

Hello @everettraven

Thanks for the hint! I ran the command and committed the changes.

everettraven · 2026-04-16T13:53:40Z

/lgtm
/approve

/ok-to-test

everettraven · 2026-04-16T13:55:03Z

/verified by @everettraven

openshift-ci-robot · 2026-04-16T13:55:15Z

@everettraven: This PR has been marked as verified by @everettraven.

Details

In response to this:

/verified by @everettraven

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-04-16T13:55:41Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

openshift-merge-bot · 2026-04-16T14:57:44Z

/retest-required

Remaining retests: 0 against base HEAD 3c6b218 and 2 for PR HEAD 3d57b9d in total

gonmmarques · 2026-04-16T19:22:46Z

/retest-required

openshift-merge-bot · 2026-04-16T22:51:51Z

/retest-required

Remaining retests: 0 against base HEAD f9587f6 and 1 for PR HEAD 3d57b9d in total

gonmmarques · 2026-04-17T10:11:32Z

/retest-required

everettraven · 2026-04-17T12:08:48Z

@gonmmarques Looks like this actually does need protobuf generation changes which I overlooked. You'll need to run make update without the PROTO_OPTIONAL=true set to generate the changes correctly for the verify check to pass.

everettraven · 2026-04-17T13:25:30Z

/lgtm

openshift-merge-bot · 2026-04-17T13:25:45Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

openshift-ci · 2026-04-17T13:25:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-04-17T15:04:49Z

/retest-required

Remaining retests: 0 against base HEAD f9587f6 and 2 for PR HEAD 137a031 in total

everettraven · 2026-04-17T19:32:40Z

/retest

openshift-ci · 2026-04-18T00:08:46Z

@gonmmarques: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

fix: small typos in comments in types.go

1e652a1

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2026

openshift-ci bot requested review from JoelSpeed and everettraven April 15, 2026 01:44

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2026

everettraven reviewed Apr 16, 2026

View reviewed changes

chore: add re-generated files

3d57b9d

openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2026

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 16, 2026

openshift-ci bot assigned everettraven Apr 16, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026

chore: regenerate files

137a031

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2026

openshift-merge-bot bot merged commit ff2999b into openshift:master Apr 18, 2026
29 checks passed

Conversation

gonmmarques commented Apr 15, 2026

Uh oh!

openshift-merge-bot bot commented Apr 15, 2026

Uh oh!

coderabbitai bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (1 inconclusive)

Uh oh!

openshift-ci bot commented Apr 15, 2026

Uh oh!

openshift-ci bot commented Apr 15, 2026

Uh oh!

everettraven left a comment

Choose a reason for hiding this comment

Uh oh!

gonmmarques commented Apr 16, 2026

Uh oh!

everettraven commented Apr 16, 2026

Uh oh!

everettraven commented Apr 16, 2026

Uh oh!

openshift-ci-robot commented Apr 16, 2026

Uh oh!

openshift-merge-bot bot commented Apr 16, 2026

Uh oh!

openshift-merge-bot bot commented Apr 16, 2026

Uh oh!

gonmmarques commented Apr 16, 2026

Uh oh!

openshift-merge-bot bot commented Apr 16, 2026

Uh oh!

gonmmarques commented Apr 17, 2026

Uh oh!

everettraven commented Apr 17, 2026

Uh oh!

everettraven commented Apr 17, 2026

Uh oh!

openshift-merge-bot bot commented Apr 17, 2026

Uh oh!

openshift-ci bot commented Apr 17, 2026

Uh oh!

openshift-merge-bot bot commented Apr 17, 2026

Uh oh!

everettraven commented Apr 17, 2026

Uh oh!

openshift-ci bot commented Apr 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Apr 15, 2026 •

edited

Loading